Skip to content

Check the whitespace of pull requests on Travis#2367

Merged
brettcannon merged 8 commits into
python:masterfrom
brettcannon:check-whitespace
Jun 24, 2017
Merged

Check the whitespace of pull requests on Travis#2367
brettcannon merged 8 commits into
python:masterfrom
brettcannon:check-whitespace

Conversation

@brettcannon

@brettcannon brettcannon commented Jun 23, 2017

Copy link
Copy Markdown
Member

@brettcannon brettcannon self-assigned this Jun 23, 2017
@brettcannon brettcannon requested a review from ncoghlan June 23, 2017 22:46
@brettcannon

brettcannon commented Jun 23, 2017

Copy link
Copy Markdown
Member Author

Since this will block PRs from being submitted if I get this wrong I won't be merging it until someone can provide me an approving review.

ncoghlan
ncoghlan approved these changes Jun 24, 2017
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion regarding the failure message, but the actual check looks good to me.

Comment thread Tools/scripts/patchcheck.py
if not fixed:
print('No whitespace issues found')
else:
print(f'Please fix the {len(fixed)} file(s) with whitespace issues')

@ncoghlan ncoghlan Jun 24, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps specifically mention make patchcheck here? It won't help Windows devs, but it's the easiest option elsewhere.

@brettcannon brettcannon merged commit 70cb187 into python:master Jun 24, 2017
@brettcannon brettcannon deleted the check-whitespace branch June 24, 2017 23:51
brettcannon added a commit to brettcannon/cpython that referenced this pull request Jun 24, 2017
@brettcannon
[3.6] Check the whitespace of pull requests on Travis (pythonGH-2367)
3306cca 
(cherry picked from commit 70cb187)
brettcannon added a commit to brettcannon/cpython that referenced this pull request Jun 24, 2017
@brettcannon
[3.5] Check the whitespace of pull requests on Travis (pythonGH-2367)
14f2684 
(cherry picked from commit 70cb187)
@bedevere-bot

bedevere-bot commented Jun 24, 2017

Copy link
Copy Markdown

GH-2386 is a backport of this pull request to the 3.6 branch.

@bedevere-bot

bedevere-bot commented Jun 24, 2017

Copy link
Copy Markdown

GH-2387 is a backport of this pull request to the 3.5 branch.

brettcannon added a commit that referenced this pull request Jun 25, 2017
@brettcannon
[3.6] Check the whitespace of pull requests on Travis (GH-2367) (GH-2386
57ee0c8 
)

(cherry picked from commit 70cb187)
brettcannon added a commit that referenced this pull request Jun 25, 2017
@brettcannon
[3.5] Check the whitespace of pull requests on Travis (GH-2367) (GH-2387
4b1468f 
)

(cherry picked from commit 70cb187)
@miss-islington

miss-islington commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

Sorry, @brettcannon, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

@brettcannon brettcannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brettcannon @bedevere-bot @miss-islington @ncoghlan @Mariatta @the-knights-who-say-ni